feat: provide docker image hosted on ghcr.io#97
Open
y-nk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would close #94 🙏
The CI is built around 2 actions, one triggering at merge and only publishing new version when you bump the package.json version, and it would call a 2nd one. I find this pattern most useful when need to re-trigger a broken docker build without having to bump the version again.
This is manual, as in, you need to bump the version by yourself, but it's also the less opinionated. You could want to implement semantic releases or any other automated release system too.
PS: sorry for the closed PRs, github ui has this need to select upstream rather than origin by default and i was too fast in opening my PRs 🙏