Skip to content

feat: add detour date and reason filter#3161

Open
stevejrowe wants to merge 20 commits intomainfrom
srowe/add-detour-date-filter
Open

feat: add detour date and reason filter#3161
stevejrowe wants to merge 20 commits intomainfrom
srowe/add-detour-date-filter

Conversation

@stevejrowe
Copy link
Contributor

@stevejrowe stevejrowe commented Mar 26, 2026

Asana Ticket: Detours Table | Add Date Filter to Closed Detours Table

Attempted to consolidate our filter form styling a bit:

  • bootstraps input-group is just a little too different structurally to be useful, so added input-group-filter to extra-bespoke. It extends the bootstrap form-control class, and is mostly comprised of mixins I put in ui_kit so that they can be applied separately if we need another bespoke input
  • override bootstraps select-filter so that the default "all" value matches the gray in the rest of the filters for dropdowns.
  • For the most part the hover and focus shadows / colors should match between all input/selects.
  • Icons have also all been consolidated to 16px black and purple on hover.

DateTimePicker

  • Created dateTimePicker.tsx wrapper component - it really only exposes the options and dates value
  • Uses the new input-group-filter class with no overrides.

Reasons

  • Moved possible reasons from the activation modal to assets/src/data/detourReasons.ts to be shared with the filter.
  • Moved the column order to match new mockups
  • Memoized the filters now that there are so many more

Moved the clear button out of header

  • really moved the title inside of the "DetourTable" so that the clear button still has the state values declared in there.

Updated the following inputs to use the new styling:

  • route ladder - route text filter, garage combobox
  • search map - text filter, filter results combobox
  • past detours - route select, intersection text filter

@stevejrowe stevejrowe marked this pull request as ready for review March 26, 2026 20:40
@stevejrowe stevejrowe requested a review from a team as a code owner March 26, 2026 20:40
@stevejrowe stevejrowe requested review from bfauble and removed request for a team March 26, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant