Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Ticket: Detours Table | Add Date Filter to Closed Detours Table
Attempted to consolidate our filter form styling a bit:
input-group-filtertoextra-bespoke. It extends the bootstrapform-controlclass, and is mostly comprised of mixins I put inui_kitso that they can be applied separately if we need another bespoke inputselect-filterso that the default "all" value matches the gray in the rest of the filters for dropdowns.DateTimePicker
Reasons
assets/src/data/detourReasons.tsto be shared with the filter.Moved the clear button out of header
Updated the following inputs to use the new styling: