"Reset to Center" and "Zoom to Drawing" Functions#264
"Reset to Center" and "Zoom to Drawing" Functions#264tafode wants to merge 2 commits intombrlabs:mainfrom
Conversation
|
I'm not sure if this feature is still needed/wanted, but I have re-implemented the logic, so that it works now with the new Godot 4.3 version. |
|
Yes, I know and I agree. 👍 |
|
I didn't mean to say that I don't have time for it. I just wanted to say that there were more important features that were reviewed/merged. It shouldn't be a problem for me to move the functions to the status bar, I just want to know from the maintainer first whether the functions are wanted at all and, if so, where. Before I invest more of my time. If you have the time and desire to help with the project, you are more than welcome to go through the issues, choose something, and implement it. |
|
So I think we have the same opinion. My main reason for my first message was to check on whether this feature was going to be added or removed, given that there is still an open issue regarding this. Thanks for the guidance on how to implement the issues, see #355 for this one 🙃 |
|
I'm not opposed to adding these features, but i don't think the toolbar is the right place because you probably won't use these enough to justify such a prominent place. It's also kind of hard to pick icons for these that make sense. I thought they could maybe go into the menu somewhere but i never thought about the status bar as buttons. Good idea, i would merge that! However please make sure that they are transparent and look like the lables right now. I would also add a bit of a hover effect (maybe a faint border outline) and a "Reset" tooltip. |
|
So, now the reset is triggered by the buttons in the statusbar, I removed the resetting of the zoom to 1 when clicking on position, as this makes no sense in the current implementation. Also re-named everything to be consistent resetting position / zoom. |

As described in #233 I have created two new buttons in the toolbar. One for resetting the camera to center/home (position 0/0 with Zoom 1) and one that zooms out so that the whole drawing is shown.
I'm not sure if the Icons are clear enough. So I'm open for suggestions. Additionally they don't match exactly the style of the others.
Known issues with this solution: