Skip to content

Add Dev Container Support#407

Open
RyanEwen wants to merge 11 commits intomaziggy:0.2.1b3from
RyanEwen:feature/add_devcontainer
Open

Add Dev Container Support#407
RyanEwen wants to merge 11 commits intomaziggy:0.2.1b3from
RyanEwen:feature/add_devcontainer

Conversation

@RyanEwen
Copy link
Contributor

Description

Add VSCode Dev Container definitions. Allows developing Bambuddy within a perfectly consistent environment regardless of the developer's OS and installed packages.

https://code.visualstudio.com/docs/devcontainers/containers

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Changes Made

  • Add the dev container definition files.

Additional Notes

To use this, open the project in a compatible IDE such as VS Code. You should automatically be prompted to reopen the project in a container. Upon accepting, dep will automatically be installed. Simply run the backend and frontend afterwards.

This is just a start. Rules can be added to the definition to enforce linting etc, if not already picked up from the existing project files.

@RyanEwen RyanEwen requested a review from maziggy as a code owner February 17, 2026 05:23
@RyanEwen RyanEwen changed the title Feature/add devcontainer Add Dev Container Support Feb 17, 2026
@maziggy maziggy changed the base branch from main to 0.2.0b February 17, 2026 05:40
Copy link
Owner

@maziggy maziggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python version mismatch (high)

The Dockerfile uses python:1-3.11-bookworm but our production Dockerfile uses python:3.13-slim. pyproject.toml sets >=3.11 as the minimum, not the target — running dev on 3.11 could mask 3.12+ behavior differences. Please update to:

FROM mcr.microsoft.com/devcontainers/python:1-3.13-bookworm

host: '0.0.0.0' in vite.config.ts should be conditional (high)

This change is needed inside Docker for port forwarding, but it also affects every developer running npm run dev locally — their Vite dev server will now listen on all
network interfaces instead of just localhost, which is a security concern on shared networks.

Could you make it conditional? For example:

server: {
host: process.env.DEVCONTAINER === 'true' ? '0.0.0.0' : undefined,
proxy: { ... }
}

And add DEVCONTAINER: "true" to .devcontainer/docker-compose.yml environment.

Minor items:

  • Node version is 20 in the devcontainer but 22 in the production Dockerfile — worth aligning to Node 22 for consistency (setup_22.x)
  • The import reorder in vite.config.ts is unrelated cosmetic churn — would prefer keeping the diff minimal and reverting that

@RyanEwen
Copy link
Contributor Author

Good catches. That's on me for not double-checking the versions when using helpers to make the dev container.

@maziggy maziggy changed the base branch from 0.2.0b to 0.2.1b February 18, 2026 10:31
@@ -0,0 +1,20 @@
FROM mcr.microsoft.com/devcontainers/python:1-3.13-bookworm

Check notice

Code scanning / Trivy

No HEALTHCHECK defined Low

Artifact: .devcontainer/Dockerfile
Type: dockerfile
Vulnerability DS-0026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS-0026
@maziggy maziggy changed the base branch from 0.2.1b to 0.2.1 February 19, 2026 14:01
@maziggy maziggy changed the base branch from 0.2.1 to 0.2.1b2 February 20, 2026 13:33
@maziggy maziggy changed the base branch from 0.2.1b2 to 0.2.1b3 February 21, 2026 19:12
@maziggy
Copy link
Owner

maziggy commented Mar 7, 2026

Please rebase with branch 0.2.3b1 and also change target branch to 0.2.3b1.

@maziggy
Copy link
Owner

maziggy commented Mar 14, 2026

Do you want to continue this?

@RyanEwen
Copy link
Contributor Author

Do you want to continue this?

Yes. I am to take a look this weekend. Big family/life things came up lately.

@maziggy
Copy link
Owner

maziggy commented Mar 14, 2026

All good. Just wanted to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants