Allow advanced filtering using and:, or: and not:#782
Merged
maxwroc merged 3 commits intomaxwroc:vNextfrom Feb 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the card’s entity filtering system to support composite filters using boolean combinators (not:, and:, or:), enabling more expressive include/exclude rules in configuration.
Changes:
- Introduces composite filter types (
NotFilter,AndFilter,OrFilter) plus acreateFilter()factory to build filter trees. - Updates battery provider to build filters via
createFilter()and updates typings to allow composite filter specs. - Expands unit tests to cover
not,and, andorbehavior.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/other/filter.test.ts | Switches tests to createFilter() and adds coverage for not/and/or combinators. |
| src/typings.d.ts | Adds FilterSpec recursive type and updates card config typing to accept composite filters. |
| src/filter.ts | Refactors filter implementation into an abstract base + composite filters and adds createFilter() factory. |
| src/battery-provider.ts | Uses createFilter() when building include/exclude filters from config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
@cr7pt0gr4ph7 thank you for contribution (sorry for such a long wait time) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve filtering capabilities by allowing composite filters using the usual combinators.