Use 'GeoIP'/'GeoLite' branding in documentation#412
Open
oschwald wants to merge 3 commits into
Open
Conversation
MaxMind no longer ships the legacy products, so refer to the products as 'GeoIP' and 'GeoLite' rather than 'GeoIP2'/'GeoLite2' in prose. Technical identifiers (packages, class names, filenames, edition IDs, hostnames, URLs) are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
horgh
requested changes
May 29, 2026
| /// An object containing GeoIP2 and minFraud Insights information about | ||
| /// An object containing GeoIP and minFraud Insights information about | ||
| /// the IP address. | ||
| /// </summary> |
Contributor
There was a problem hiding this comment.
From Claude, not sure though:
- Missed prose — MaxMind.MinFraud/Response/GeoIP2Location.cs:8: "A subclass of the GeoIP2 Location model with minFraud-specific…". Analogous to docs updated in
IPAddress.cs/Insights.cs. The class name GeoIP2Location stays, but the prose "GeoIP2 Location model" should switch.
Update the docblock prose to say GeoIP; the GeoIP2Location class name is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates prose/documentation to refer to the products as "GeoIP"/"GeoLite" instead of "GeoIP2"/"GeoLite2". Technical identifiers (packages, class names, .mmdb filenames, edition IDs, the geolite.info hostname, URLs) are unchanged.
🤖 Generated with Claude Code