Stop searching in further dirs on errors except ENOENT#41
Open
leonerd wants to merge 1 commit intomauke:masterfrom
Open
Stop searching in further dirs on errors except ENOENT#41leonerd wants to merge 1 commit intomauke:masterfrom
leonerd wants to merge 1 commit intomauke:masterfrom
Conversation
|
@leonerd |
justinmk
pushed a commit
to neovim/unibilium
that referenced
this pull request
Aug 11, 2019
if a terminfo file was found during the directory search, loaded, and then found to contain an error, the search continues into other locations. If this eventually fails, the error is always ENOENT, thus swallowing the reason that the file which was found, had errored. This PR changes the behaviour, stopping on the first error that is not ENOENT. ref: mauke#41
|
Merged in https://github.com/neovim/unibilium. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if it was intentional, but if a terminfo file was found during the directory search, loaded, and then found to contain an error, the search continues into other locations. If this eventually fails, the error is always
ENOENT, thus swallowing the reason that the file which was found, had errored.This PR changes the behaviour, stopping on the first error that is not
ENOENT.