Correct handling of SQLITE_TEXT during Change Data Capture#1352
Open
otoolep wants to merge 2 commits intomattn:masterfrom
Open
Correct handling of SQLITE_TEXT during Change Data Capture#1352otoolep wants to merge 2 commits intomattn:masterfrom
otoolep wants to merge 2 commits intomattn:masterfrom
Conversation
otoolep
changed the title
rittneje
reviewed
Sep 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of SQLITE_TEXT data types during Change Data Capture operations in the SQLite pre-update hook functionality. The fix corrects how text values are extracted from SQLite value objects to ensure proper string handling.
- Replaces manual byte-based text extraction with proper C string conversion
- Removes redundant length calculation for text values
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
Not sure what "no good" meant, I assume you meant the Copilot review is no good? |
Owner
Yes, it is. |
Contributor
Author
|
"Yes it is good and you need to change your code", or "yes, it is no good, the code right now looks good". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.