Add option to set target directory for archiving actions#81
Add option to set target directory for archiving actions#81Timongcraft wants to merge 3 commits intomattmalec:developfrom
Conversation
Added the ability to specify a directory for both compression and decompression actions. This directory determines where the compressed archive will be put and where the archive to be decompressed is located, respectively.
…les from a directory.
|
hey curious how this compares to putting the compressed file in the directory you want it to exist in? for example if you want to decompress in /a and the file is in /a, would it not decompress there? |
|
Could we probably use that as the default, or what specifically do you suggest |
|
oh i thought that was the existing behavior and this pr just let you explicitly do what the library already did automatically |
|
If I remember correctly, it would always be placed in the main directory. I would need to look at it again to confirm that, though. |
|
But if that was not what you meant, then what did you mean? |
|
the file should ideally extract into whatever directory the file is in - if that's not the case, it's definitely a bug |
|
Yeah, it always decompresses by default into the root folder, including the old version. |
|
that would be great! |
I mean, it was asked for here. And you told me to make a pr. I don't really have a use case for it atm as I used it just as a temporal solution. But I guess you could use it for anotherr form of backups or syncing. It's not that you can't do it without this, but otherwise, it's just a pain to move around the files before or after a backup/sync. If the application you're hosting monitors the root directory, it could potentially cause issues (probably very niche, Ik). |
Adds the option to set a root directory in both the CompressionAction and DecomressionAction.
This directory determines where the compressed archive will be put or where the archive to be decompressed is located, respectively.