Skip to content

Added functionality to remove code after a /*DEV*/ comment#436

Open
downhiller wants to merge 1 commit intomatthiasmullie:masterfrom
downhiller:downhiller-patch-1
Open

Added functionality to remove code after a /*DEV*/ comment#436
downhiller wants to merge 1 commit intomatthiasmullie:masterfrom
downhiller:downhiller-patch-1

Conversation

@downhiller
Copy link
Copy Markdown

I can see that back in Nov 2017 @tetrode added a similar PR that never got merged. Hopefully this one will.

(This is my first ever OSS contribution and pull request, so apologies if I've done it wrong...!)

Copy link
Copy Markdown

@tetrode tetrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally :-), thanks

@downhiller
Copy link
Copy Markdown
Author

As an aside, can you educate me - what's the difference between

'/\/\*DEV\*\/.*$/m' (treat dollar sign as end of line rather than end of string)

and

'/\/\*DEV\*\/.*/' (match up to the next newline/end of string)

I think nothing, but both you and @matthiasmullie have used the $ & /m variant, so I assume I'm missing some nuance!

@tetrode
Copy link
Copy Markdown

tetrode commented Jan 13, 2025 via email

@matthiasmullie matthiasmullie force-pushed the master branch 2 times, most recently from 9ddadb8 to 4c4ecee Compare March 6, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants