Strip empty props and better empty tags removal#345
Open
obedparla wants to merge 11 commits intomatthiasmullie:masterfrom
Open
Strip empty props and better empty tags removal#345obedparla wants to merge 11 commits intomatthiasmullie:masterfrom
obedparla wants to merge 11 commits intomatthiasmullie:masterfrom
Conversation
Strip empty props and better tags
matthiasmullie
force-pushed
the
master
branch
5 times, most recently
from
85ee174 to
227f190
Compare
…css vars" This reverts commit 78215e3.
- A var such as --myColor would break.
matthiasmullie
force-pushed
the
master
branch
3 times, most recently
from
949e01d to
51d1aa4
Compare
matthiasmullie
force-pushed
the
master
branch
2 times, most recently
from
9ddadb8 to
4c4ecee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #344
Since I need all these changes in my app, I went ahead and added the improvements. They're all with tests.
Happy to make any desired adjustments