Skip to content

fix: BiDi/RTL support#98

Open
alirezaalavi87 wants to merge 8 commits intomattermost:mainfrom
alirezaalavi87:fix/BiDi
Open

fix: BiDi/RTL support#98
alirezaalavi87 wants to merge 8 commits intomattermost:mainfrom
alirezaalavi87:fix/BiDi

Conversation

@alirezaalavi87
Copy link
Contributor

Summary

Fixing the issue of BiDi, RTL text in boards.

Prior, Mixing RTL and LTR text would mess the UI
"یک دو three four پنچ"
"One دو سه four"

as you can see, Github also renders BiDi text correctly by adding dir=auto to text fields.

@alirezaalavi87
Copy link
Contributor Author

@Rajat-Dabade
Can you look at this?

@Rajat-Dabade
Copy link
Contributor

@alirezaalavi87 Can you fix the tests which are failing? Thank you.

Alireza Alavi added 2 commits May 28, 2025 11:30
By adding text-align: left, the RTL text doesn't overflow from the
container. This isn't a very good fix, but a fix nonetheless
Some tests on the CI are failing but not in local dev.
@alirezaalavi87
Copy link
Contributor Author

alirezaalavi87 commented May 28, 2025

@Rajat-Dabade
I can't recreate the errors in my dev environment.
most of them are related to the snapshot test, I don't know how to update the snapshots and it isn't documented.
Rest of them are related to element keys for lists (which I didn't change in this PR).

running make ci returns this:

cd webapp; npm run test

> [email protected] test
> NODE_ENV=test jest



Test Suites: 0 of 149 total
Tests:       0 total
Snapshots:   0 total
Time:        0 smake: *** [Makefile:395: webapp-ci] Bus error (core dumped)

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@alirezaalavi87
Copy link
Contributor Author

@alerque @Rajat-Dabade

Hi guys.

I still can't run the test and get the same error.
Maybe help me fix the issue or accept the changes.

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants