Open
Conversation
Contributor
Author
|
@Rajat-Dabade |
Contributor
|
@alirezaalavi87 Can you fix the tests which are failing? Thank you. |
added 2 commits
May 28, 2025 11:30
By adding text-align: left, the RTL text doesn't overflow from the container. This isn't a very good fix, but a fix nonetheless
Some tests on the CI are failing but not in local dev.
Contributor
Author
|
@Rajat-Dabade running |
alerque
approved these changes
May 30, 2025
Contributor
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Contributor
Author
|
Hi guys. I still can't run the test and get the same error. thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the issue of BiDi, RTL text in boards.
Prior, Mixing RTL and LTR text would mess the UI
"یک دو three four پنچ"
"One دو سه four"
as you can see, Github also renders BiDi text correctly by adding
dir=autoto text fields.