Fixed critical bugs in Mattermost Boards plugin

[Rajat-Dabade]

Summary

• Added safety checks so the app doesn’t crash if multiPerson isn’t a string, or if date values have extra spaces or invalid JSON.
• Added nil check in HasPermissionToBoard to prevent nil pointer dereference.
• Added fallback in GetFilePath to check legacy location (filename) when teamID == GlobalTeamID and the standard path doesn't exist.
• Reordered CopyCardFiles to copy and verify files before saving FileInfo, skipping missing source files gracefully.
• Updated CopyAndUpdateCardFiles to remove file references for missing files and update in-memory blocks after database patches to ensure the frontend receives the correct file IDs.
• Added nil check for fileReader in handleServeFile to prevent panic.

Summary by CodeRabbit

• Bug Fixes
  • Fixed potential application crashes during file operations and permission checks
  • Enhanced file lookup to support legacy file location fallbacks
  • Improved file copying with deduplication and pre-copy validation
  • Strengthened validation for date formats and multi-person property values with better error handling
  • Added additional safety checks to permission verification workflows

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch critical-error-board

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[larkox]

I wonder if we want to add tests for any of these.

[mm-cloud-bot]

Plugin Spinwick PR #169 🎉

Test server created!

Access here: https://boards-pr-169-hw3a8.test.mattermost.cloud

Plugin	Version	Artifact
boards	c84c23f	Download

⚠️ Plugin Installation Issue

The test server was created successfully, but there was an issue installing or enabling the plugin automatically:

• Install Error: failed to wait for S3 artifact: timed out waiting for S3 artifact

You can manually install the plugin:

1. Download the plugin artifact from the link above
2. Upload it to your test server at w1h8oeep6irqzd56hq4xs5n98a
3. Enable it in System Console > Plugins

Future commits will still attempt to automatically update the plugin.

Installation ID: w1h8oeep6irqzd56hq4xs5n98a
Logs: Click here

Credentials: Posted securely in this Mattermost channel - Look for PR #169

[Rajat-Dabade]

@harshilsharma63 A friendly reminder for review. Thank you.

[Rajat-Dabade]

I wonder if we want to add tests for any of these.

@larkox For now, the tests are not running board. Will cover it separately in #155 PR.

[harshilsharma63]

@Rajat-Dabade do we have a test server with this boards patch deployed?

[Rajat-Dabade]

@harshilsharma63 boards-pr-169-hw3a8.test.mattermost.cloud

Spinwick created a test server, you can test on it.

[mm-cloud-bot]

Test server destroyed