feat: Add support for requiring that all non-nil methods be called#244
Open
nicholascapo wants to merge 1 commit intomatryer:mainfrom
Open
feat: Add support for requiring that all non-nil methods be called#244nicholascapo wants to merge 1 commit intomatryer:mainfrom
nicholascapo wants to merge 1 commit intomatryer:mainfrom
Conversation
Signed-off-by: Nicholas Capo <nicholas@capo.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At
$day_jobwe have a helper that sets a mock function, and then resets it after the test is done (usingt.Cleanup()).When we have a moq with a nil function that gets called, the test panics, and then we implement the mocked function.
This change adds support for making the reverse assertion: Non-nil mock functions must be called in the tests.
If a non-nil function has not been called when the test ends, the helper fails the test, and then we can remove the mock function.
This might not be useful for everyone, so we add a
-with-require-callsCLI flag, and theRequireCalls()function only returns an error.