fix: provide admin credentials for TPCC synccommit - #408
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dump/111test credentials tomo-load-datathroughSYNC_USERandSYNC_PASStpcc_test:adminas the account used for TPCC DDL and data loadingWhy
mo_ctl(synccommit)requiressys:moadmin. The TPCC loader currently reusestpcc_test:admin, so the barrier is rejected and a followingLOAD DATAcan race catalog visibility across CNs.Companion loader change: matrixorigin/mo-load-data#18.
Related issue: matrixorigin/matrixone#26313.
Validation
.github/workflows/merge-trigger-tke.yamlas YAMLload_tpcc_datastep receives string valuesSYNC_USER=dumpandSYNC_PASS=111git diff --checkMerge order
Merge this PR before matrixorigin/mo-load-data#18. The current loader ignores these environment variables, so this change is backward compatible and prevents a CI failure window when the loader begins failing fast.