Skip to content

fix: tolerate missing Compose coverage on legacy branches - #406

Merged
aptend merged 1 commit into
mainfrom
fix/legacy-compose-coverage
Jul 27, 2026
Merged

fix: tolerate missing Compose coverage on legacy branches#406
aptend merged 1 commit into
mainfrom
fix/legacy-compose-coverage

Conversation

@aptend

@aptend aptend commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it

Legacy MatrixOne branches such as 4.2-dev do not mount /coverage or set GOCOVERDIR in their Compose configuration. Their Compose BVT can therefore pass while the reusable workflow fails afterward when it requires a coverage profile.

This change:

  • keeps the successful Compose BVT result when the checked-out legacy Compose configuration has no coverage wiring;
  • still requires both BVT coverage profiles on main;
  • lets legacy branches merge UT plus standalone BVT coverage when only Compose coverage is unsupported;
  • retains both BVT manifests, so complementary group and generation validation is unchanged.

Observed in MatrixOne run: https://github.com/matrixorigin/matrixone/actions/runs/30250338336

Testing

  • git diff --check
  • exercised main/legacy profile-count branches and Compose capability detection with shell fixtures
  • verified main still rejects a missing Compose profile

@aptend
aptend merged commit a7e4b38 into main Jul 27, 2026
1 check passed
@aptend
aptend deleted the fix/legacy-compose-coverage branch July 27, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant