feat(ui): introduce a new ThreadListService#6311
Open
stefanceriu wants to merge 4 commits intomainfrom
Open
Conversation
`ThreadListService` is the FFI-facing wrapper around [`matrix_sdk_ui::timeline::thread_list_service::ThreadListService`]. It maintains an observable list of [`ThreadListItem`]s and exposes a pagination state publisher, making it straightforward to build reactive UIs on top of the thread list.
…e new `ThreadListService`
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6311 +/- ##
==========================================
+ Coverage 89.81% 89.88% +0.06%
==========================================
Files 376 376
Lines 102461 102646 +185
Branches 102461 102646 +185
==========================================
+ Hits 92026 92261 +235
+ Misses 6855 6809 -46
+ Partials 3580 3576 -4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadListServiceis the FFI-facing wrapper around [matrix_sdk_ui::timeline::thread_list_service::ThreadListService].It maintains an observable list of [
ThreadListItem]s and exposes a pagination state publisher, making it straightforward to build reactive UIs on top of the thread list.This PR also removes the existing
Room:load_thread_listmethod in favor of this new service.Part of #6290