Skip to content

chore(sdk): Log errors from EventLinkedChunk #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hywan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(sdk): Log errors from EventLinkedChunk #6235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/matrix-sdk/src/event_cache/caches/event_linked_chunk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use matrix_sdk_common::linked_chunk::{
AsVector, Chunk, ChunkIdentifier, Error, Iter, IterBackward, LinkedChunk, ObservableUpdates,
Position,
};
use tracing::trace;
use tracing::{instrument, trace};

/// This type represents a linked chunk of events for a single room or thread.
#[derive(Debug)]
Expand Down Expand Up @@ -102,6 +102,7 @@ impl EventLinkedChunk {
///
/// This method returns the position of the (first if many) newly created
/// `Chunk` that contains the `items`.
#[instrument(err, skip_all, fields(gap_identifier, sentry = true))]
fn replace_gap_at(
&mut self,
gap_identifier: ChunkIdentifier,
Expand Down Expand Up @@ -140,6 +141,7 @@ impl EventLinkedChunk {
/// Remove some events from the linked chunk.
///
/// If a chunk becomes empty, it's going to be removed.
#[instrument(err, skip_all, fields(positions, sentry = true))]
pub fn remove_events_by_position(&mut self, mut positions: Vec<Position>) -> Result<(), Error> {
sort_positions_descending(&mut positions);

Expand All @@ -154,6 +156,7 @@ impl EventLinkedChunk {
///
/// `position` must point to a valid item, otherwise the method returns an
/// error.
#[instrument(err, skip_all, fields(position, sentry = true))]
pub fn replace_event_at(&mut self, position: Position, event: Event) -> Result<(), Error> {
self.chunks.replace_item_at(position, event)
}
Expand Down Expand Up @@ -426,6 +429,7 @@ impl EventLinkedChunk {
///
/// This clears all the chunks in memory before resetting to the new chunk,
/// if provided.
#[instrument(err, skip_all, fields(sentry = true))]
pub(in super::super) fn replace_with(
&mut self,
last_chunk: Option<RawChunk<Event, Gap>>,
Expand All @@ -439,6 +443,7 @@ impl EventLinkedChunk {
}

/// Prepends a lazily-loaded chunk at the beginning of the linked chunk.
#[instrument(err, skip_all, fields(sentry = true))]
pub(in super::super) fn insert_new_chunk_as_first(
&mut self,
raw_new_first_chunk: RawChunk<Event, Gap>,
Expand Down
Loading