Skip to content

Support for MSC4388 for the QR login#6173

Draft
poljar wants to merge 16 commits intomainfrom
poljar/qr-login/msc4388
Draft

Support for MSC4388 for the QR login#6173
poljar wants to merge 16 commits intomainfrom
poljar/qr-login/msc4388

Conversation

@poljar
Copy link
Contributor

@poljar poljar commented Feb 13, 2026

  • Public API changes documented in changelogs (optional)

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 96.15385% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (acda2e8) to head (6fc3247).
⚠️ Report is 45 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cation/oauth/qrcode/rendezvous_channel/msc_4388.rs 95.79% 11 Missing and 2 partials ⚠️
...tion/oauth/qrcode/secure_channel/crypto_channel.rs 67.85% 0 Missing and 9 partials ⚠️
.../authentication/oauth/qrcode/secure_channel/mod.rs 94.44% 4 Missing and 4 partials ⚠️
...hentication/oauth/qrcode/rendezvous_channel/mod.rs 89.47% 0 Missing and 4 partials ⚠️
...atrix-sdk/src/authentication/oauth/qrcode/grant.rs 98.26% 0 Missing and 2 partials ⚠️
...atrix-sdk/src/authentication/oauth/qrcode/login.rs 99.21% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6173      +/-   ##
==========================================
+ Coverage   89.91%   90.01%   +0.10%     
==========================================
  Files         374      375       +1     
  Lines      102613   103414     +801     
  Branches   102613   103414     +801     
==========================================
+ Hits        92267    93092     +825     
+ Misses       6783     6765      -18     
+ Partials     3563     3557       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing poljar/qr-login/msc4388 (6fc3247) with main (81bed18)

Open in CodSpeed

@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from e50a48d to 2379010 Compare February 16, 2026 08:58
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch 2 times, most recently from fb95097 to 5849fcc Compare February 25, 2026 11:20
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch 2 times, most recently from c5dc751 to 631a247 Compare March 12, 2026 14:23
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from 631a247 to 22a9115 Compare March 13, 2026 09:58
@poljar poljar force-pushed the poljar/qr-login/msc4388 branch from fc70d24 to 036dd95 Compare March 18, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants