chore(ffi): use ruma's built-in uniffi support for power levels#6161
chore(ffi): use ruma's built-in uniffi support for power levels#6161Johennes wants to merge 1 commit intomatrix-org:mainfrom
Conversation
0afd17b to
e0e9256
Compare
Signed-off-by: Johannes Marbach <[email protected]>
e0e9256 to
5acec1d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6161 +/- ##
=======================================
Coverage 89.79% 89.80%
=======================================
Files 365 365
Lines 100469 100469
Branches 100469 100469
=======================================
+ Hits 90215 90224 +9
+ Misses 6721 6714 -7
+ Partials 3533 3531 -2 ☔ View full report in Codecov by Sentry. |
|
This is failing the complement-crypto tests now. These downgrade uniffi to 0.28.3. This no longer works because ruma's new uniffi support depends on changes from uniffi 0.31.0. In particular:
I can think of the following ways to resolve this:
I'm not sure which of these is worse but maybe I've missed a better option? |
|
The better option is to help move NordSecurity/uniffi-bindgen-go#86 forward, IMHO. |
That's still two minor versions behind what ruma needs but, yes, ideally the complement crypto tests wouldn't have to downgrade uniffi in the first place. |
|
Yeah, but it would unblock additional upgrades (which may be much easier than that one, if you're lucky ^^). |
This is the smallest possible way that I could find to start using ruma/ruma#2338 in the FFI bindings. It doesn't really improve much on its own because the types that were replaced here are still used elsewhere. I thought it'd be good to start small though.
The only difference of the two types in the foreign language should be the use of
Customvs.Other.