Make tests compatible with newer phpunit versions

[williamdes]

Description:

• Non breaking changes for newer phpunit versions (running on PHPUnit 11.1.3 at Debian)
• Fixing the parameter names for newer PHP versions (Error: Unknown named parameter $check)
• Upgrade GitHub actions
• Allow newer PHPunit versions up to 12
• Fix deprecations in tests

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

Why should the variable name need to contain a _? What is the problem with useragent? This doesn't comply with our coding style.

[williamdes]

Weird CI failures, new commits broke something or is it my diff ?

[liviuconcioiu]

Not sure, but probably the PHPUnit workflow should be updated too so it can use composer update? Now it tries to run PHPUnit 11 on PHP 7.2.

I installed PHP 7.2.5 (this is the lowest version required by symfony/yaml 5.1.7) and the tests pass.

[williamdes]

Not sure, but probably the PHPUnit workflow should be updated too so it can use composer update? Now it tries to run PHPUnit 11 on PHP 7.2.

I installed PHP 7.2.5 (this is the lowest version required by symfony/yaml 5.1.7) and the tests pass.

Oh snap, let's revert that part. I only need the PHP diff anyway
PRs like #7570 can update that

[williamdes]

I dropped the last commit, it should help

[liviuconcioiu]

@williamdes can you fix the conflicts? And also you should also add static to getFixturesDeviceTypeFromClientHints. It was added after your PR.

[williamdes]

I did some ajustements as I am quite sure the ignore should not have been used for all versions and this way.

[sanchezzzhak]

Run local php vendor/bin/phpcbf for fix phpcs

[liviuconcioiu]

@williamdes is it possible to update the workflow so it does look like this?

Right now it looks like this:

Those are missing (pending but aren't running):

PHPUnit (windows-latest, 8.4)
PHPUnit (macos-latest, 8.4)

[williamdes]

@williamdes is it possible to update the workflow so it does look like this?

Not really (I have no options to change the text), can it be merged as is @sgiehl ?
I have one more PR for phpunit 12 afterwards

[williamdes]

Hi @sgiehl
Can you check this one please ?

[liviuconcioiu]

1. You should run ./vendor/bin/phpcbf to fix the phpcs errors - https://github.com/matomo-org/device-detector/actions/runs/20045151285/job/57507861303?pr=7727

2. You can add to composer, so we get rid of scrapbook deprecations

        "psr/cache": "^1.0.1 || ^2.0 || ^3.0",
        "psr/simple-cache": "^1.0.1 || ^2.0 || ^3.0",

Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading matthiasmullie/scrapbook (1.4.9 => 1.5.4)
  - Upgrading psr/cache (1.0.1 => 3.0.0)
  - Upgrading psr/simple-cache (1.0.1 => 3.0.0)

3. On PHP 8.5 there are some deprecations - https://github.com/matomo-org/device-detector/actions/runs/20045151287/job/57507861394?pr=7727

3) E:\GitHub\device-detector\Tests\Parser\Client\BrowserTest.php:118
Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect

4) E:\GitHub\device-detector\Tests\Parser\Client\BrowserTest.php:122
Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect

5) E:\GitHub\device-detector\Tests\Parser\Client\BrowserTest.php:145
Method ReflectionMethod::setAccessible() is deprecated since 8.5, as it has no effect

Probably is a good idea to add this

if (PHP_VERSION_ID < 80500) {
    $browserProperty->setAccessible(true);
}

[williamdes]

Thank you @liviuconcioiu !
Can someone approve the workflows ?

Edit: phpcs is fixed, all will go green now

[sanchezzzhak]

The tests are completed.
The code has been verified.
Everything looks good, I'm combining it.
Thank you all for involved.

[williamdes]

Can you tag a new release some time soon so I can import the version into Debian?

[liviuconcioiu]

Can you tag a new release some time soon so I can import the version into Debian?

@williamdes a new version has just been released.