Allow setting the aria-current property using the route and active actions. - #173
Open
david-nordvall wants to merge 2 commits into
Open
Allow setting the aria-current property using the route and active actions.#173david-nordvall wants to merge 2 commits into
aria-current property using the route and active actions.#173david-nordvall wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While setting CSS classes on anchor elements is useful for creating visual cues, in many cases it is better to use the
aria-currentproperty. In addition to be useful in styling and visual changes, it is also an important cue for screen readers.This PR adds support for setting the
aria-currentproperty using therouteandactiveactions. This is done by expanding theRouteOptionstype with the memberariaCurrent. Any value in the current state of this member is applied to the anchor element'saria-currentproperty. TheRouteOptionsmemberclassesis left unchanged. This means that this change does not affect existing users of the library and that CSS classes can be applied using therouteandactiveactions along side applyingaria-currentvalues.