Added a custom key function in server side#6
Closed
bensu wants to merge 1 commit intomartinklepsch:masterfrom
Closed
Added a custom key function in server side#6bensu wants to merge 1 commit intomartinklepsch:masterfrom
bensu wants to merge 1 commit intomartinklepsch:masterfrom
Conversation
Owner
|
You're on a roll! 👍 If you have an example it'd be great if you could add it to the changelog (just use "unreleased" or something like that as heading.) Also are there any other changes to the Readme required to be in sync with the new message format for the |
…e data on client side.
Contributor
Author
|
Forgot to document! While adding the changes to the README I produced a conflict. After solving it I can't push it into this branch, so I'm opening a new PR with the non-conflict changes in #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now provide a
:key-fnto the server handler which givenfile-nameandmime-typewill determine the key to use for the S3 file.Caveat: if the client provides a file
my-file.txtand the:key-fngenerates a random number as a key (i.e.12314345), the file location in S3 is given by12314345, which is what was passed back in thes3-pipeuploaded channel. The file location is no longer sufficient for the client to know which file was successfully uploaded (in case of parallel uploads).My (non-backwards-compatible) proposal is to put in the
uploadedchannel all information relevant to the client: both the file object that was uploaded and the response from S3 which contains the:key,:location,:bucket, and:etag.