Skip to content

chore: improve test suite to run hydrate entry#3152

Merged
DylanPiercey merged 1 commit intomainfrom
opencode/witty-cactus
Apr 2, 2026
Merged

chore: improve test suite to run hydrate entry#3152
DylanPiercey merged 1 commit intomainfrom
opencode/witty-cactus

Conversation

@DylanPiercey
Copy link
Copy Markdown
Contributor

  • updates resume test suite to use compiled hydrate entry instead of manual "init" calls

@DylanPiercey DylanPiercey self-assigned this Apr 2, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

⚠️ No Changeset found

Latest commit: e8b53db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.57%. Comparing base (9874646) to head (e8b53db).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3152   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         370      370           
  Lines       47086    47086           
  Branches     4271     4270    -1     
=======================================
  Hits        42177    42177           
  Misses       4857     4857           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey merged commit 2f4148d into main Apr 2, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Apr 2, 2026
@DylanPiercey DylanPiercey deleted the opencode/witty-cactus branch April 2, 2026 19:06
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This pull request modifies the test implementation in packages/runtime-tags/src/__tests__/main.test.ts. The changes include removing the dependency on the ServerRenderer type and the ___id extraction from server-rendered templates. Fixture loading is updated to use fixtureDir instead of __dirname. The resume() flow is reworked to compile a separate CJS hydrate artifact from the template file and execute it via browser.window.Function with injected require binding, rather than calling init or initEmbedded directly. The changes also simplify the resume logic by eliminating embedded-specific branching and removing the preliminary template require call.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: improving the test suite to use a compiled hydrate entry instead of manual initialization calls.
Description check ✅ Passed The description clearly relates to the changeset by explaining the shift from manual 'init' calls to using a compiled hydrate entry in the resume test suite.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch opencode/witty-cactus

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant