chore: remove manual test file logic

[DylanPiercey]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 17f9da7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Removed manual_csr, manual_ssr, and manual_resume from TestConfig and removed logic that selected alternate fixture entrypoints (server.ts, browser.ts, resume.ts). Execution gating for SSR/CSR/resume now uses skip_html/skip_dom with skip_ssr/skip_csr/skip_resume and error_compiler (with skip_resume enabled unless explicitly false). Templates always load template.marko. Snapshot compilation uses a fresh new Map() per snapAllTemplates call. SSR compiler registration moved into a per-fixture before(). babelConfig now sets browserslistConfigFile: false. Mocha now logs the initial require error via console.error(requireErr) before ESM fallback.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a description explaining the rationale for removing manual test file logic and how the new execution gating approach works.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: remove manual test file logic' accurately describes the main change in the PR, which removes manual_csr, manual_ssr, and manual_resume flags from TestConfig.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch opencode/witty-cactus

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/runtime-tags/src/__tests__/main.test.ts (1)

31-42: ⚠️ Potential issue | 🟠 Major

Remove unused manual_* properties from interop.test.ts TestConfig type.

The manual_csr, manual_ssr, and manual_resume properties were removed from main.test.ts but remain defined (but unused) in interop.test.ts lines 34-36. Remove these from the TestConfig type definition in interop.test.ts to maintain consistency between the two test files.

No fixture files depend on these removed properties.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/runtime-tags/src/__tests__/main.test.ts` around lines 31 - 42,
Remove the now-unused manual_csr, manual_ssr, and manual_resume properties from
the TestConfig type definition (symbol: TestConfig) in the interop.test.ts test
file so it matches main.test.ts; simply delete those three property declarations
from the TestConfig type and run a quick search for any references to
manual_csr/manual_ssr/manual_resume to ensure nothing else depends on them.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@packages/runtime-tags/src/__tests__/main.test.ts`:
- Around line 31-42: Remove the now-unused manual_csr, manual_ssr, and
manual_resume properties from the TestConfig type definition (symbol:
TestConfig) in the interop.test.ts test file so it matches main.test.ts; simply
delete those three property declarations from the TestConfig type and run a
quick search for any references to manual_csr/manual_ssr/manual_resume to ensure
nothing else depends on them.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a702b19c-de52-4fd8-ad14-1acab99dd503

📥 Commits

Reviewing files that changed from the base of the PR and between 906fcb8 and 2b2bbcf.

📒 Files selected for processing (1)

• packages/runtime-tags/src/__tests__/main.test.ts

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.57%. Comparing base (906fcb8) to head (17f9da7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3150   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         370      370           
  Lines       47080    47080           
  Branches     4269     4269           
=======================================
  Hits        42171    42171           
  Misses       4857     4857           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/runtime-tags/src/__tests__/main.test.ts`:
- Around line 100-106: config.error_compiler can be true or a string[] so using
it directly in OR gates treats empty arrays as truthy; introduce a boolean like
errorCompilerFlag (e.g., const errorCompilerFlag = config.error_compiler ===
true || (Array.isArray(config.error_compiler) && config.error_compiler.length >
0)) and then replace direct uses of config.error_compiler in the skip logic
(skipSSR, skipCSR, skipResume) with this boolean so empty arrays do not
incorrectly mark skips.
- Around line 84-98: The SSR and CSR configs (ssrCompileOpts and csrCompileOpts)
currently share the same cache Map from compileOpts due to shallow spread,
causing cross-contamination; fix by giving each config its own cache instance
(e.g., set cache: new Map() when creating ssrCompileOpts and cache: new Map()
when creating csrCompileOpts) so SSR and CSR compilations do not reuse the same
cached artifacts.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8999da7b-f70a-4d1d-94aa-a5bfd850d8dc

📥 Commits

Reviewing files that changed from the base of the PR and between d8d3b52 and 17f9da7.

📒 Files selected for processing (4)

• packages/runtime-tags/src/__tests__/fixtures/rest-tag-var/index.marko
• packages/runtime-tags/src/__tests__/fixtures/rest-tag-var/test.js
• packages/runtime-tags/src/__tests__/main.test.ts
• patches/mocha+11.7.5.patch

✅ Files skipped from review due to trivial changes (1)

• patches/mocha+11.7.5.patch