MLE-31105: Created PR to test run Jenkins changes - #194
Open
barkhachoithani wants to merge 1 commit into
Open
Conversation
…s-minikube-shards MLE-31105: e2e Test parallelization POC Merging POC PR to verify the test parallelization on Jenkins.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a proof-of-concept “true parallel” Minikube e2e execution mode for CI by sharding the suite across isolated Minikube profiles, and wires it into the Jenkins pipeline while collecting timing/log artifacts.
Changes:
- Added a new
test/timing/minikube-true-parallel-pack.shrunner that executes Minikube setup/test/cleanup per shard in parallel and writes timing/log artifacts. - Extended
Jenkinsfilewith shard-mode parameters, a sharded Minikube execution path, and artifact archiving for shard timing outputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/timing/minikube-true-parallel-pack.sh | New parallel shard runner that times and logs per-shard setup/test/cleanup and emits CSV/log artifacts. |
| Jenkinsfile | Adds shard-mode parameters, runs the shard pack when enabled, and archives shard timing/log outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+185
to
+198
| awk -F',' ' | ||
| NR > 1 { | ||
| key = $2 "/" $3 | ||
| sum[key] += $4 | ||
| count[key] += 1 | ||
| failed[key] += ($5 != 0) | ||
| } | ||
| END { | ||
| printf "%-34s %-10s %-10s\n", "shard/phase", "avg_s", "failures" | ||
| for (k in sum) { | ||
| printf "%-34s %-10.2f %-10d\n", k, sum[k] / count[k], failed[k] | ||
| } | ||
| } | ||
| ' "${CSV_FILE}" | sort |
Comment on lines
+454
to
+457
| echo 'Shard pack manages setup internally per shard.' | ||
| if (!params.VERIFY_HELM_NAMESPACE_SCOPED) { | ||
| echo 'USE_MINIKUBE_SHARDS runs cluster + Helm namespace suites; VERIFY_HELM_NAMESPACE_SCOPED is ignored for this path.' | ||
| } |
Comment on lines
+166
to
+181
| void runMinikubeShardedE2eTests(String shardCount = '2', boolean runIstio = true, boolean runVolumeResize = true, boolean isolateMinikubeHome = true, String kubernetesVersion = 'v1.31.0') { | ||
| if (!(shardCount in ['2', '3'])) { | ||
| error "Unsupported Minikube shard count '${shardCount}'. Supported values: 2, 3" | ||
| } | ||
|
|
||
| sh """ | ||
| SHARDS=${shardCount} \\ | ||
| REPEATS=1 \\ | ||
| RUN_ISTIO=${runIstio ? 1 : 0} \\ | ||
| RUN_VOLUME_RESIZE=${runVolumeResize ? 1 : 0} \\ | ||
| ISOLATE_MINIKUBE_HOME=${isolateMinikubeHome ? 1 : 0} \\ | ||
| E2E_KUBERNETES_VERSION=${kubernetesVersion} \\ | ||
| IMG=${operatorRepo}:${VERSION} \\ | ||
| bash test/timing/minikube-true-parallel-pack.sh | ||
| """ | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLE-31105: e2e Test parallelization POC