Update VIN extraction to filter non-alphanumeric characters - #1045
Merged
Conversation
Sanitize VIN variable to remove non-alphanumeric characters.
Sanitize VIN by removing non-alphanumeric characters.
marcone
reviewed
May 5, 2026
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| VIN=$(sudo grep "^export TESLA_BLE_VIN=" /root/teslausb_setup_variables.conf | cut -d'=' -f2- | head -n 1) | |||
Owner
There was a problem hiding this comment.
This will do for now as a quick fix, but I think it makes more sense to source /root/teslausb_setup_variables.conf (or source /root/bin/envsetup.sh) instead of trying to parse it manually.
It might even make sense to create a wrapper for fcgiwrap so that the environment is set for all the fcgiwrap processes.
Author
There was a problem hiding this comment.
yeah, I was just modifying what was in place already
DennisGarvey
added a commit
to DennisGarvey/teslausb
that referenced
this pull request
May 5, 2026
Update VIN extraction to filter non-alphanumeric characters (marcone#1045)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitize VIN variable to remove non-alphanumeric characters.