Implement global zoom controls in the status bar#4435
Open
Aayushmaan-24 wants to merge 1 commit intomapeditor:masterfrom
Open
Implement global zoom controls in the status bar#4435Aayushmaan-24 wants to merge 1 commit intomapeditor:masterfrom
Aayushmaan-24 wants to merge 1 commit intomapeditor:masterfrom
Conversation
Reintroduced global zoom controls in the MainWindow status bar (mZoomSlider, mZoomEdit, mZoomInButton, mZoomOutButton) and improved the connection logic to safely handle cases where the active Zoomable may be null. Removed the redundant mZoomComboBox from MapEditor and TilesetEditor, allowing these larger editors to rely on the global status bar zoom controls. Retained the compact mZoomComboBox in dock-based views where horizontal space is limited (TilesetDock, WangDock, TileCollisionDock, TileAnimationEditor) so those views continue to have a convenient zoom control. Addresses maintainer feedback about space constraints in the Tilesets view while avoiding UI redundancy.
Aayushmaan-24
force-pushed
the
feature-4432-zoom-slider
branch
from
f2df507 to
6f2dacd
Compare
Member
|
@Aayushmaan-24 My changes from #4429 seem to have become part of your commit. Please rebase it on latest Since you're changing UI, could you add some screenshots of how it looks with your changes? |
Author
|
I get it. I have attached some screenshots of the changes but I do need more details on how to proceed with rebasing on the latest master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the individual zoom dropdown (QComboBox) controls found in various editors with a single, global set of zoom controls in the main window status bar.
Fixes #4432
Key Changes
Global Zoom Controls: Added Zoom In/Out buttons, a slider, and a percentage text field to the MainWindow status bar.
Removed Redundancy: Removed local zoom dropdowns from the Map Editor, Tileset Editor, Tileset Dock, Tile Collision Dock, and Tile Animation Editor.
Synchronization: The global zoom controls are automatically synchronized with the active editor's zoom level.
Consistency: Provides a more modern and unified user interface experience for zoom management across the application.
Motivation
The previous implementation had redundant controls in multiple places, taking up valuable screen space and creating an inconsistent user experience. Moving these to a global status bar location streamlines the interface and makes zoom easier to control.
Verification
Open Tiled.
Open a Map and observe the zoom slider in the status bar.
Use the slider, buttons, or type a percentage to confirm the map zooms correctly.
Switch to the Tileset Dock or Tileset Editor and verify the global slider updates to reflect the current zoom level.