Change visibilty to hidden on OSX/clang#40677
Open
rosswhitfield wants to merge 41 commits intomantidproject:mainfrom
Open
Change visibilty to hidden on OSX/clang#40677rosswhitfield wants to merge 41 commits intomantidproject:mainfrom
rosswhitfield wants to merge 41 commits intomantidproject:mainfrom
Conversation
64aa13a to
8dec0d4
Compare
Member
|
Since it messes with the state of OSX builders, this is going to wait until after the v6.14 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
This sets
CMAKE_CXX_VISIBILITY_PRESET=hiddenfor clang/OSX so it matches Linux/Windows.There are a number of fixes that were needed to make this work as you can see:
libMantid*and exported with correct visibility.LogManager::getInvalidValuesFilterIt may require a clean build on OSX.
Closes #39159
To test:
CI + code review
This does not require release notes because internal change only not visible to users.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: