[ABI BREAK] abis: Fix definition of fd_set#1658
Open
Dennisbonke wants to merge 1 commit intomanagarm:masterfrom
Open
[ABI BREAK] abis: Fix definition of fd_set#1658Dennisbonke wants to merge 1 commit intomanagarm:masterfrom
Dennisbonke wants to merge 1 commit intomanagarm:masterfrom
Conversation
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
from
dbbf75c to
a67660c
Compare
Mathewnd
changed the title
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
3 times, most recently
from
f826ec3 to
62b86ad
Compare
no92
requested changes
Jan 12, 2026
|
|
||
| typedef struct __attribute__((__aligned__(__alignof__(long)))) { | ||
| __mlibc_uint8 fds_bits[128]; | ||
| typedef long int __fd_mask; |
Member
There was a problem hiding this comment.
While I get that the linux kernel has this as long, making this signed breaks our implementations of the FD_* macros.
| typedef struct { | ||
| /* libtirpc reaches into fds_bits directly, so we must keep the name and type exactly as expected. | ||
| * This now matches the definition in sys/select.h from glibc. */ | ||
| __fd_mask fds_bits[FD_SETSIZE / __NFDBITS]; |
Member
There was a problem hiding this comment.
We might want to have the name of this be switched between this and a double underscore-prefixed variant based on the appropriate feature test macros, as earlier POSIX specs required this name, while current ones don't.
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
3 times, most recently
from
c92cf08 to
859e25b
Compare
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
3 times, most recently
from
eb3f878 to
afb2571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.