DRC: Minimise the number of pages that need protection changes#14774
Merged
cuavas merged 1 commit intomamedev:masterfrom Jan 9, 2026
Merged
DRC: Minimise the number of pages that need protection changes#14774cuavas merged 1 commit intomamedev:masterfrom
cuavas merged 1 commit intomamedev:masterfrom
Conversation
cpu/drcbeut.cpp: Allocate (misnamed) hash table blocks from the permanent cache area so they aren't intermixed with executable code. cpu/drccache.cpp: Only mark pages writable starting from the beginning of unused space.
Member
Author
|
I've seen no objections, and I have other DRC stuff to do that will benefit from having this in place. |
rb6502
pushed a commit
that referenced
this pull request
Jan 9, 2026
cpu/drcbeut.cpp: Allocate (misnamed) hash table blocks from the permanent cache area so they aren't intermixed with executable code. cpu/drccache.cpp: Only mark pages writable starting from the beginning of unused space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how the misleadingly named "DRC hash table" allocates lookup table blocks. This changes it to allocate larger blocks of memory from the "permanent allocation" area at the end of the cache, rather than allocating smaller "temporary" blocks intermixed with executable code.
This has a number of effects:
I doubt this will actually have much impact on performance in practice, as even changing protection on a single page requires an expensive page table flush. But I still think it's a cleaner approach to managing memory.