-
Notifications
You must be signed in to change notification settings - Fork 2.3k
concept: Use 1.7 ROM by default #14771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eschaton
wants to merge
1
commit into
mamedev:master
Choose a base branch
from
eschaton:eschaton/concept-17-rom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change to the labels here? We usually use "." format for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm not up on the terminology—which strings are you referring to as labels? I'm happy to change it however you like.
The Corvus code sometimes says "Version 1 Level 7" and sometimes "V1.7" and sometimes "1.7" while the code in the file uses "lvl" for the other values. For the filenames, I just lowercased the names of the files on Bitsavers, I could use exactly the same name or use the names from the removed code, it's all fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quoted strings, e.g.
"ccb17h.bin", are called “labels” – MAME does use as file names when searching for assets. We usually try to format these by putting the label/mask code/etc. from the chips (in lowercase with restricted character set) before the final dot, and the PCB location afterwards.For example
"mon_4-000-v_2.1.a1"was from a chip labeled “MON 4-000-v 2.1” at PCB location A1 in an Intel development system.Do you know what the labels and PCB locations for these chips are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! I can check my Concepts for the PCB locations. (I assume a socket number like U37 would be ideal while grid location would be acceptable?)
Unfortunately I don't have the 1.7 ROMs in my Concepts so I can't check them for label/mask code/etc., and I don't think anything like that was recorded for the dumps on Bitsavers. Al does that when he can, so I expect the ROMs may have been hand-labeled.