[GIT-254] Refactor: Store consolidation to @core/store by codingwolf-at · Pull Request #9271 · makeplane/plane

codingwolf-at · 2026-06-19T12:05:15Z

Description

Moved stores from apps/web/ce/store to apps/web/core/store

Type of Change

Code refactoring

…e application

…e core module

…rt paths in the core module

…new base timeline store

…cross the application

…type references

…git-254/store-consolidation-core-store

…s across various components

CLAassistant · 2026-06-19T12:05:22Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

coderabbitai · 2026-06-19T12:05:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8074101f-e448-421a-8e08-2f207a28e876

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch git-254/store-consolidation-core-store

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-19T12:05:49Z

React Doctor found 24 issues in 9 files · 24 warnings · score 86 / 100 (Great) · vs git-248/components-consolidation-core-components

24 warnings

app/(all)/[workspaceSlug]/(projects)/extended-sidebar.tsx

⚠️ L38 Chained array iterations js-combine-iterations
⚠️ L68 Pure function rebuilt every render prefer-module-scope-pure-function

core/components/issues/delete-issue-modal.tsx

⚠️ L45 Derived state stored in an effect no-derived-state-effect

core/components/issues/issue-detail-widgets/relations/content.tsx

⚠️ L109 Chained array iterations js-combine-iterations

core/components/issues/issue-detail-widgets/relations/quick-action-button.tsx

⚠️ L60 Array index used as a key no-array-index-as-key

core/components/issues/issue-detail/issue-activity/activity/actions/relation.tsx

⚠️ L15 Import from a barrel file no-barrel-import

core/components/issues/issue-layouts/kanban/kanban-group.tsx

⚠️ L47 Import from a barrel file no-barrel-import
⚠️ L130 Multiple setState calls in one effect no-cascading-set-state
⚠️ L187 Missing effect dependencies exhaustive-deps
⚠️ L265 Click handler missing keyboard handler click-events-have-key-events
⚠️ L265 Interaction on static element no-static-element-interactions

core/components/issues/issue-layouts/list/headers/group-by-card.tsx

⚠️ L114 Click handler missing keyboard handler click-events-have-key-events
⚠️ L114 Interaction on static element no-static-element-interactions
⚠️ L149 Click handler missing keyboard handler click-events-have-key-events
⚠️ L149 Interaction on static element no-static-element-interactions

core/components/issues/issue-layouts/list/list-group.tsx

⚠️ L38 Import from a barrel file no-barrel-import
⚠️ L135 Click handler missing keyboard handler click-events-have-key-events
⚠️ L135 Interaction on static element no-static-element-interactions
⚠️ L179 Multiple setState calls in one effect no-cascading-set-state
⚠️ L240 Missing effect dependencies exhaustive-deps
⚠️ L242 Missing effect dependencies exhaustive-deps

core/lib/store-context.tsx

⚠️ L12 Non-component export in component file only-export-components
⚠️ L14 Non-component export in component file only-export-components
⚠️ L23 Non-component export in component file only-export-components

_{Reviewed by React Doctor for commit 09b373e. See inline comments for fixes.}

makeplane · 2026-06-19T12:05:50Z

Linked to Plane Work Item(s)

(GIT-254) Store consolidation to @core/store

This comment was auto-generated by Plane

github-actions · 2026-06-19T12:05:51Z

-import { RootStore } from "@/plane-web/store/root.store";
+import { RootStore } from "@/store/root.store";

 export let rootStore = new RootStore();


React Doctor · react-doctor/only-export-components (warning)

This file exports non-components, so Fast Refresh can't safely preserve component state.

Fix → Move non-component exports out of component files so Fast Refresh can preserve component state instead of full-reloading.

Docs

github-actions · 2026-06-19T12:05:51Z

 import { useTimeLineRelationOptions } from "@/components/relations";
-import type { TIssueRelationTypes } from "@plane/types";
 // local helpers
 import { IssueActivityBlockComponent } from "./";


React Doctor · react-doctor/no-barrel-import (warning)

This ships extra code to your users & slows page load. Import directly from "./helpers/activity-block".

Fix → Import from the direct path: import { Button } from './components/Button' instead of ./components

Docs

github-actions · 2026-06-19T12:05:51Z

+// local imports
 import { GroupDragOverlay } from "../group-drag-overlay";
 import type { TRenderQuickActions } from "../list/list-view-types";
 import { KanbanQuickAddIssueButton, QuickAddIssueRoot } from "../quick-add";


React Doctor · react-doctor/no-barrel-import (warning)

This ships extra code to your users & slows page load. Import directly from: "../quick-add/button/kanban", "../quick-add/root".

Fix → Import from the direct path: import { Button } from './components/Button' instead of ./components

Docs

github-actions · 2026-06-19T12:05:51Z

-//
+// local imports
 import { GroupDragOverlay } from "../group-drag-overlay";
 import { ListQuickAddIssueButton, QuickAddIssueRoot } from "../quick-add";


React Doctor · react-doctor/no-barrel-import (warning)

This ships extra code to your users & slows page load. Import directly from: "../quick-add/button/list", "../quick-add/root".

Fix → Import from the direct path: import { Button } from './components/Button' instead of ./components

Docs

codingwolf-at added 8 commits June 19, 2026 15:53

refactor: remove unused store files and update import paths across th…

ec7dfde

…e application

refactor: remove unused store files and update import paths across th…

c68728c

…e core module

refactor: remove unused issue filter and store files, and update impo…

b496d21

…rt paths in the core module

refactor: update import paths for timeline store files and introduce …

1fca1d1

…new base timeline store

refactor: remove deprecated root store file and update import paths a…

0294af9

…cross the application

refactor: update import paths for store files and correct root store …

89f78c0

…type references

Merge branch 'git-248/components-consolidation-core-components' into …

312ddc9

…git-254/store-consolidation-core-store

refactor: standardize import comments and remove 'plane-web' artifact…

09b373e

…s across various components

codingwolf-at requested review from Rahulcheryala and prateekshourya29 June 19, 2026 12:05

codingwolf-at requested a review from sriramveeraghanta as a code owner June 19, 2026 12:05

github-actions Bot reviewed Jun 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GIT-254] Refactor: Store consolidation to @core/store#9271

[GIT-254] Refactor: Store consolidation to @core/store#9271
codingwolf-at wants to merge 8 commits into
git-248/components-consolidation-core-componentsfrom
git-254/store-consolidation-core-store

codingwolf-at commented Jun 19, 2026

Uh oh!

CLAassistant commented Jun 19, 2026

Uh oh!

coderabbitai Bot commented Jun 19, 2026

Review skipped

Uh oh!

github-actions Bot commented Jun 19, 2026

Uh oh!

makeplane Bot commented Jun 19, 2026

Uh oh!

github-actions Bot Jun 19, 2026

Uh oh!

github-actions Bot Jun 19, 2026

Uh oh!

github-actions Bot Jun 19, 2026

Uh oh!

github-actions Bot Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

codingwolf-at commented Jun 19, 2026

Description

Type of Change

Uh oh!

CLAassistant commented Jun 19, 2026

Uh oh!

coderabbitai Bot commented Jun 19, 2026

Review skipped

Uh oh!

github-actions Bot commented Jun 19, 2026

Uh oh!

makeplane Bot commented Jun 19, 2026

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants