Skip to content

fix(UpdatePanel): add zip type to semver-based update checks #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meteyou merged 3 commits into from
Jun 16, 2026
Merged

fix(UpdatePanel): add zip type to semver-based update checks #2444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f29d3d5
fix: add zip type to semver-based update checks
prestonbrown Feb 19, 2026
813f1b4
refactor: extract isSemverType computed property to deduplicate type …
prestonbrown Feb 21, 2026
a3f801f
fix(Entry): update zip type handling in version output template
meteyou Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/components/panels/Machine/UpdatePanel/Entry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
{{ versionOutput }}
</a>
</template>
<template v-else-if="(type === 'web' || type === 'executable') && semverUpdatable">
<a class="info--text text-decoration-none" :href="webLinkRelease" target="_blank">
<template v-else-if="type === 'python' && semverUpdatable">
<a class="info--text text-decoration-none" :href="pythonChangelog" target="_blank">
<v-icon small color="info" class="mr-1">{{ mdiUpdate }}</v-icon>
{{ versionOutput }}
</a>
</template>
<template v-else-if="type === 'python' && semverUpdatable">
<a class="info--text text-decoration-none" :href="pythonChangelog" target="_blank">
<template v-else-if="isSemverType && semverUpdatable">
<a class="info--text text-decoration-none" :href="webLinkRelease" target="_blank">
<v-icon small color="info" class="mr-1">{{ mdiUpdate }}</v-icon>
{{ versionOutput }}
</a>
Expand Down Expand Up @@ -172,6 +172,10 @@ export default class UpdatePanelEntry extends Mixins(BaseMixin) {
return this.repo.configured_type
}

get isSemverType() {
return ['executable', 'python', 'web', 'zip'].includes(this.type)
}

get localVersion() {
const version = this.repo.version ?? '?'
if (!semver.valid(version, { loose: true })) return null
Expand Down Expand Up @@ -271,15 +275,15 @@ export default class UpdatePanelEntry extends Mixins(BaseMixin) {
if (['printing', 'paused'].includes(this.printer_state)) return true
if (!this.isValid || this.isCorrupt || this.isDirty || this.commitsBehind.length) return false

if (['python', 'web', 'executable'].includes(this.type)) return !this.semverUpdatable
if (this.isSemverType) return !this.semverUpdatable

return this.commitsBehind.length === 0
}

get btnIcon() {
if (this.isDetached || !this.isValid || this.isCorrupt || this.isDirty) return mdiCloseCircle

if (['python', 'web', 'executable'].includes(this.type)) {
if (this.isSemverType) {
if (this.semverUpdatable) return mdiProgressUpload
else if (this.localVersion === null || this.remoteVersion === null) return mdiHelpCircleOutline
}
Expand All @@ -292,7 +296,7 @@ export default class UpdatePanelEntry extends Mixins(BaseMixin) {
get btnColor() {
if (this.isCorrupt || this.isDetached || this.isDirty || !this.isValid) return 'orange'

if (['python', 'web', 'executable'].includes(this.type) && this.semverUpdatable) return 'primary'
if (this.isSemverType && this.semverUpdatable) return 'primary'
if (this.type === 'git_repo' && this.commitsBehind.length) return 'primary'

return 'green'
Expand All @@ -304,7 +308,7 @@ export default class UpdatePanelEntry extends Mixins(BaseMixin) {
if (this.isDirty) return this.$t('Machine.UpdatePanel.Dirty')
if (!this.isValid) return this.$t('Machine.UpdatePanel.Invalid')

if (['python', 'web', 'executable'].includes(this.type)) {
if (this.isSemverType) {
if (this.semverUpdatable) return this.$t('Machine.UpdatePanel.Update')
else if (this.localVersion === null || this.remoteVersion === null)
return this.$t('Machine.UpdatePanel.Unknown')
Expand Down
Loading