Skip to content

Importing MagicalRecord+ShorthandMethods.h in MagicalRecord.h - Issue 1276#1281

Open
amleszk wants to merge 2 commits intomagicalpanda:masterfrom
amleszk:fix_swift_compilation_1276
Open

Importing MagicalRecord+ShorthandMethods.h in MagicalRecord.h - Issue 1276#1281
amleszk wants to merge 2 commits intomagicalpanda:masterfrom
amleszk:fix_swift_compilation_1276

Conversation

@amleszk
Copy link
Copy Markdown
Contributor

@amleszk amleszk commented Dec 28, 2016

@Coeur Coeur self-assigned this May 30, 2019
@Coeur
Copy link
Copy Markdown
Collaborator

Coeur commented May 30, 2019

Thank you.

  1. I couldn't reproduce any compilation error, as written in the linked issue (use_frameworks! causes error: include of non-modular header inside framework module 'MagicalRecord.MagicalRecord_ShorthandMethods' #1276).
  2. Changing #import <MagicalRecord/MagicalRecord.h> to #import <MagicalRecord/MagicalRecordInternal.h> is nice, so I'm cherry picking it in Improved ShorthandMethods imports #1350.
  3. As for adding #import <MagicalRecord/MagicalRecord+ShorthandMethods.h> in the umbrella header, I don't know. It wasn't there for the past 3 years. Currently, I don't even know what is this enableShorthandMethods, so I would need more enlightening regarding its usage and usefulness. I'll leave the Pull Request open, but with a different title.

@Coeur Coeur changed the title Fix swift compilation using cocoapods use_frameworks! - Issue 1276 Importing MagicalRecord+ShorthandMethods.h in MagicalRecord.h - Issue 1276 May 30, 2019
@Coeur Coeur removed their assignment May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants