Skip to content

PWA-3642: Canonical url support#4597

Merged
del22123 merged 1 commit intorelease/14.5from
PWA-3642
Jan 29, 2026
Merged

PWA-3642: Canonical url support#4597
del22123 merged 1 commit intorelease/14.5from
PWA-3642

Conversation

@del15881
Copy link
Collaborator

Description

Added Canonical URL support to PWA.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3642

Closes #PWA-3642.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 added enhancement New feature or request version: Minor This changeset includes functionality added in a backwards compatible manner. labels Jan 28, 2026
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 934de1d

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 934de1d

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jan 28, 2026

Messages
📖

Associated JIRA tickets: PWA-3642.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 934de1d

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

Details
Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-9735b646.json

Generated by 🚫 dangerJS against 934de1d

@del22123
Copy link
Collaborator

Run pr-test

@del22123
Copy link
Collaborator

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jan 29, 2026

Successfully started codebuild job for pr-test

@del22123 del22123 merged commit c931e36 into release/14.5 Jan 29, 2026
7 of 14 checks passed
@del22123 del22123 deleted the PWA-3642 branch February 13, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pkg:peregrine pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants