40564: Added support for 'disabled' state for individual select options#40565
Open
rybkinevg wants to merge 5 commits intomagento:2.4-developfrom
Open
Conversation
|
Hi @rybkinevg. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Added support for the
disabledproperty on individual<option>elements within select form fields.If the
disabledkey is set totruein the option array it renders thedisabled="disabled"attribute accordingly.Fixed Issues (if relevant)
Manual testing scenarios (*)
№1 Modify the builtin source model:
Open the file:
app/code/Magento/Config/Model/Config/Source/Yesno.phpand modify thetoOptionArray()method to adddisabledproperty to the "No" option:№2 Clear Cache
№3 Navigate to admin configuration area
Go to
Stores->Configuration->General->Web, expand theUrl Optionssection№4 Verify the "Add Store Code to Urls" Field
Click on the dropdown to expand the options, the "No" option is disabled
Questions or comments
Current implementation treats all truthy values of the
disabledproperty as the disabled state:I am not sure, is this correct, or should we treat only explicitly true values as disabled state? For example:
Contribution checklist (*)