Skip to content

Allow forward slash in telephone number validation#40545

Open
marvincaspar wants to merge 1 commit intomagento:2.4-developfrom
marvincaspar:feature/allow-slash-in-telephone-validation
Open

Allow forward slash in telephone number validation#40545
marvincaspar wants to merge 1 commit intomagento:2.4-developfrom
marvincaspar:feature/allow-slash-in-telephone-validation

Conversation

@marvincaspar
Copy link

@marvincaspar marvincaspar commented Feb 19, 2026

Description (*)

Magento’s telephone number validation currently rejects phone numbers that contain slashes (/). However, slashes are commonly used in German phone number formatting (e.g. 030/1234567 or 089/12345-0).

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Allow slashes in telephone number #40544

Manual testing scenarios (*)

  1. Edit a customer address and set telephone number to 0123/456789 and save it

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2026

Hi @marvincaspar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@marvincaspar
Copy link
Author

@magento run all tests

@marvincaspar
Copy link
Author

@engcom-Bravo, the functional and integration tests are failing but thats not because of my change. Can you please verify. From my point of view the PR is ready to review/merge

@hostep
Copy link
Contributor

hostep commented Mar 3, 2026

It looks like the core dev team fixed this as well by now, see: ACP2E-4554: Address Validators Breaking Existing Customer after upgrade to 2.4.8-p3

@marvincaspar: I believe we can close this PR now, do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Allow slashes in telephone number

3 participants