Skip to content

fix(quote): change applied_rule_ids column type to text in quote table#40540

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39838-quote-applied-rule-ids-column-type
Open

fix(quote): change applied_rule_ids column type to text in quote table#40540
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39838-quote-applied-rule-ids-column-type

Conversation

@lbajsarowicz
Copy link
Contributor

Description (*)

The applied_rule_ids column in the quote table was defined as VARCHAR(255), while the same column in quote_item and quote_address_item tables was defined as TEXT. With 100+ sales rules applied to a single item, the comma-separated list of rule IDs can exceed 255 characters, causing data truncation and mismatches between parent and child tables.

Changed quote.applied_rule_ids from VARCHAR(255) to TEXT to ensure consistency with quote_item.applied_rule_ids and quote_address_item.applied_rule_ids.

Related Pull Requests

No related pull requests

Fixed Issues

Fixes #39838

Manual testing scenarios (*)

  1. Apply 100+ sales rules to a product
  2. Add the product to a cart
  3. Verify that all applied rule IDs are saved correctly in the quote table without truncation
  4. Compare quote.applied_rule_ids with quote_item.applied_rule_ids — they should match

Questions or comments

No questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

The applied_rule_ids column in the quote table was defined as
VARCHAR(255), while the same column in quote_item and quote_address_item
tables was defined as TEXT. With 100+ sales rules applied to a single
item, the comma-separated list of rule IDs can exceed 255 characters,
causing data truncation and mismatches between parent and child tables.

Changed quote.applied_rule_ids from VARCHAR(255) to TEXT to ensure
consistency with quote_item.applied_rule_ids and
quote_address_item.applied_rule_ids.

Fixes magento#39838
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P3 May be fixed according to the position in the backlog. labels Feb 24, 2026
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

Data Type of applied_rule_ids in Quote and Quote Item is different

2 participants