fix(quote): change applied_rule_ids column type to text in quote table#40540
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix(quote): change applied_rule_ids column type to text in quote table#40540lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
The applied_rule_ids column in the quote table was defined as VARCHAR(255), while the same column in quote_item and quote_address_item tables was defined as TEXT. With 100+ sales rules applied to a single item, the comma-separated list of rule IDs can exceed 255 characters, causing data truncation and mismatches between parent and child tables. Changed quote.applied_rule_ids from VARCHAR(255) to TEXT to ensure consistency with quote_item.applied_rule_ids and quote_address_item.applied_rule_ids. Fixes magento#39838
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
The
applied_rule_idscolumn in thequotetable was defined asVARCHAR(255), while the same column inquote_itemandquote_address_itemtables was defined asTEXT. With 100+ sales rules applied to a single item, the comma-separated list of rule IDs can exceed 255 characters, causing data truncation and mismatches between parent and child tables.Changed
quote.applied_rule_idsfromVARCHAR(255)toTEXTto ensure consistency withquote_item.applied_rule_idsandquote_address_item.applied_rule_ids.Related Pull Requests
No related pull requests
Fixed Issues
Fixes #39838
Manual testing scenarios (*)
quotetable without truncationquote.applied_rule_idswithquote_item.applied_rule_ids— they should matchQuestions or comments
No questions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz