Skip to content

Add format parameter to DateFormatterFactory#40530

Open
marvincaspar wants to merge 5 commits intomagento:2.4-developfrom
marvincaspar:fix/intl-date-format
Open

Add format parameter to DateFormatterFactory#40530
marvincaspar wants to merge 5 commits intomagento:2.4-developfrom
marvincaspar:fix/intl-date-format

Conversation

@marvincaspar
Copy link

@marvincaspar marvincaspar commented Feb 13, 2026

Description (*)

Fixes incorrect datetime parsing caused by using locale-dependent IntlDateFormatter::parse() without an explicit pattern when processing ISO-formatted datetime strings.

Magento currently creates an IntlDateFormatter using SHORT date/time styles and then parses values such as:

YYYY-MM-DD HH:MM:SS

However, SHORT formats are locale-dependent (e.g. dd.MM.yy HH:mm in de_DE) and do not match ISO datetime strings. As a result, parsing is undefined and may produce incorrect timestamps instead of failing.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes IntlDateFormatter::parse() misparses ISO datetime string in PHP 8.4 (returns incorrect date) #40524

Manual testing scenarios (*)

$formatter = new \IntlDateFormatter(
    'de_DE',
    \IntlDateFormatter::SHORT,
    \IntlDateFormatter::SHORT,
    'UTC',
    null,
    'yyyy-MM-dd HH:mm:ss'
);

$timestamp = $formatter->parse('2026-02-10 10:49:38');
var_dump(date('Y-m-d H:i:s', $timestamp));

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2026

Hi @marvincaspar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@marvincaspar
Copy link
Author

@magento run all tests

@marvincaspar
Copy link
Author

@magento run all tests

@marvincaspar
Copy link
Author

@magento run Static Tests, Unit Tests

@marvincaspar
Copy link
Author

@magento run Static Tests

@marvincaspar
Copy link
Author

@magento run all tests

@marvincaspar
Copy link
Author

@magento run all tests

@marvincaspar
Copy link
Author

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 17, 2026
@marvincaspar
Copy link
Author

@engcom-Bravo, the functional and integration tests are failing but thats not because of my change. Can you please verify. From my point of view I'm ready with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

IntlDateFormatter::parse() misparses ISO datetime string in PHP 8.4 (returns incorrect date)

2 participants