Add format parameter to DateFormatterFactory#40530
Add format parameter to DateFormatterFactory#40530marvincaspar wants to merge 5 commits intomagento:2.4-developfrom
Conversation
|
Hi @marvincaspar. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Static Tests, Unit Tests |
|
@magento run Static Tests |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests |
|
@engcom-Bravo, the functional and integration tests are failing but thats not because of my change. Can you please verify. From my point of view I'm ready with this PR |
Description (*)
Fixes incorrect datetime parsing caused by using locale-dependent
IntlDateFormatter::parse()without an explicit pattern when processing ISO-formatted datetime strings.Magento currently creates an
IntlDateFormatterusingSHORTdate/time styles and then parses values such as:However,
SHORTformats are locale-dependent (e.g.dd.MM.yy HH:mminde_DE) and do not match ISO datetime strings. As a result, parsing is undefined and may produce incorrect timestamps instead of failing.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)