Migrate in-store-pickup email to strict mode

[smartexcan]

Description (*)

The In Store Pickup "Ready for pickup" notification email still used deprecated (and removed as of magento 2.4.4) variables with direct method calls.
This resulted in the affected variables in the email template not being rendered.

Fixed Issues (if relevant)

1. Fixes In Store Pickup email still using legacy methods #3384

Manual testing scenarios (*)

1. Create order with in-store-pickup
2. Send ready for pickup email
3. Check email output for customer name.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @smartexcan,

Thank you for the collaboration!

The changes seems good to us, but please refer to the below review comments:

• Cover the PR changes with some automated test in accordance to the DOD
• Sign the CLA so that we can move forward with this PR

Thank you

[smartexcan]

updated the branch and bot is reporting signed now lol

I don't know how to write tests for this, but I've been using this fix in our production deployment since i filed the PR and it working as expected.

also had a misclick on the re-review thing...

[smartexcan]

@magento run all tests

[smartexcan]

@magento run Static Tests, Unit Tests

[engcom-Hotel]

Approving this PR for further processing

[engcom-Bravo]

Hi @smartexcan,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• Create order with in-store-pickup
• Send ready for pickup email
• Check email output for customer name

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run Functional Tests EE, Integration Tests, Unit Tests

[engcom-Hotel]

Functional Tests EE Failure is known issue:
StorefrontGalleryConfigurableProductWithSeveralAttributesPrependMediaTest: https://jira.corp.adobe.com/browse/ACQE-8615

Integration test failure doesn’t related to the PR changes:

Hence merging the PR.