Product salability improvements fork#3243
Closed
novikor wants to merge 29 commits intomagento:developfrom
Closed
Conversation
This was referenced Nov 15, 2020
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run Integration Tests |
Contributor
Author
|
@magento run Functional Tests CE |
Apply code review changes.
Move bundle status check to plugin. Move configurable plugin to around. Both facts comes from fact for bundle and configurable produts, salability status is depends only on salability status of their children (and does not depend on the condition chain).
Fixed case when composite product has out of stock status.
Fix static tests.
Updated TODOs
Remove excess code.
…lability calculation from observer to plugin method to be executed on demand.
… isAvailable only.
Fixed is salable logic.
Restored Bundles support plugin for IsProductSalableChain
Tests fix and stabilizations.
Tests fix and stabilizations.
Drop test of removed logic.
Small refactoring.
Contributor
Author
|
@magento run Integration Tests |
Contributor
Author
|
@magento run Functional Tests CE |
…to#3140 Load product salability data on-demand magento#3201. Verify product statuses during salability calculation for composite products using default functionality.
Contributor
Author
|
@magento run all tests |
m2-community-project
bot
added
Progress: review
and removed
Progress: dev in progress
labels
Contributor
Author
|
The development part seems to be finished. However, there are some test cases that should be covered:
@swnsma . |
Contributor
Author
|
@magento run all tests |
Contributor
|
@magento run all tests |
swnsma
added
Award: advanced
Award: bug fix
Award: category of expertise
Auto-Tests: Not Covered
Collaborator
|
Hello @novikor, Please resolve the conflicts from this PR, so that we can move forward with this. Thank you |
engcom-Hotel
moved this from Review in Progress
to On Hold
in Inventory - Pull Request Progress
Collaborator
|
Hello @novikor, We appreciate your contribution! Since we haven't received a response from you for an extended period, we are closing this PR for now. Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you. Thanks once again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3202
Description (*)
A common version for #3140 IsProductSalable/AreProdustsSalable composite products support and #3201: Load product salability data on-demand
Fixed Issues (if relevant)
Manual testing scenarios (*)
Not now
Contribution checklist (*)