This repository was archived by the owner on Mar 16, 2020. It is now read-only.
Changes required to run on go 1.11 appengine:#351
Open
harishjp wants to merge 2 commits intomadelynnblue:masterfrom
Open
Changes required to run on go 1.11 appengine:#351harishjp wants to merge 2 commits intomadelynnblue:masterfrom
harishjp wants to merge 2 commits intomadelynnblue:masterfrom
Conversation
harishjp
commented
Mar 16, 2020
harishjp
commented
- Move to "google.golang.org/appengine/*" library
- Move logging to "google.golang.org/appengine/log"
- Update app.sample.yaml file.
- Add .gcloudignore file to ignore git files to be uploaded.
* Move to "google.golang.org/appengine/*" library * Move logging to "google.golang.org/appengine/log" * Update app.sample.yaml file. * Add .gcloudignore file to ignore git files to be uploaded.
Author
|
Hi, I've updated the code to run on go 1.11. I've been running it for a few days. Hope the change is good. |
* Remove use of log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.