Skip to content

fix: 修复满减金额计算精度问题 (Issue #492) #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Senrian wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −5
Open

fix: 修复满减金额计算精度问题 (Issue #492) #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4561277
fix: 修复满减金额计算精度问题
penggaolai Apr 4, 2026
8d1dab0
fix: 修复优惠券金额分摊计算精度问题 (Issue #356)
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions mall-portal/src/main/java/com/macro/mall/portal/service/impl/OmsPortalOrderServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,21 @@ private void handleCouponAmount(List<OmsOrderItem> orderItemList, SmsCouponHisto
*/
private void calcPerCouponAmount(List<OmsOrderItem> orderItemList, SmsCoupon coupon) {
BigDecimal totalAmount = calcTotalAmount(orderItemList);
for (OmsOrderItem orderItem : orderItemList) {
//(商品价格/可用商品总价)*优惠券面额
BigDecimal couponAmount = orderItem.getProductPrice().divide(totalAmount, 3, RoundingMode.HALF_EVEN).multiply(coupon.getAmount());
BigDecimal couponAmountTotal = coupon.getAmount();
BigDecimal remainingAmount = couponAmountTotal;
int size = orderItemList.size();
for (int i = 0; i < size; i++) {
OmsOrderItem orderItem = orderItemList.get(i);
BigDecimal couponAmount;
if (i < size - 1) {
//(商品价格/可用商品总价)*优惠券面额
couponAmount = orderItem.getProductPrice().divide(totalAmount, 3, RoundingMode.HALF_EVEN).multiply(couponAmountTotal);
remainingAmount = remainingAmount.subtract(couponAmount);
} else {
// last item gets the remainder to ensure total equals coupon amount
couponAmount = remainingAmount;
}
couponAmount = couponAmount.setScale(2, RoundingMode.HALF_UP);
orderItem.setCouponAmount(couponAmount);
}
}
Expand Down
4 changes: 2 additions & 2 deletions mall-portal/src/main/java/com/macro/mall/portal/service/impl/OmsPromotionServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ public List<CartPromotionItem> calcCartPromotion(List<OmsCartItem> cartItemList)
BeanUtils.copyProperties(item,cartPromotionItem);
String message = getFullReductionPromotionMessage(fullReduction);
cartPromotionItem.setPromotionMessage(message);
//(商品原价/总价)*满减金额
//(商品原价/总价)*满减金额，使用 multiply-divide 顺序避免 divide 精度损失
PmsSkuStock skuStock= getOriginalPrice(promotionProduct, item.getProductSkuId());
BigDecimal originalPrice = skuStock.getPrice();
BigDecimal reduceAmount = originalPrice.divide(totalAmount,RoundingMode.HALF_EVEN).multiply(fullReduction.getReducePrice());
BigDecimal reduceAmount = originalPrice.multiply(fullReduction.getReducePrice()).divide(totalAmount, 2, RoundingMode.HALF_EVEN);
cartPromotionItem.setReduceAmount(reduceAmount);
cartPromotionItem.setRealStock(skuStock.getStock()-skuStock.getLockStock());
cartPromotionItem.setIntegration(promotionProduct.getGiftPoint());
Expand Down