cdo: Another legacy build fix

[Dave-Allured]

Description

Tentative fix for 10.14 builds, maybe others.
"fatal error: 'ranges' file not found"
Blacklist clang < 900.
Build fix only. No rev bump.

Type(s)

• bugfix

Tested on

CI only.
Waiting for merge to test on builders <= 10.14.

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@remkos for port cdo.
@tenomoto for port cdo.

[remkos]

Yes, we keep on tweeking the use or exclusion of clang. Let's hope this holds for a while.

[Dave-Allured]

Follow up for CDO. This PR DID NOT FIX BUILD FOR MACOS 10.14. Blacklist clang < 900 was not the right solution for "fatal error: 'ranges' file not found".

Maybe try blacklisting higher clang version number, or some other compiler constraint. I believe this is a known problem, a relatively simple problem of compiler selection and legacy support. Need to follow up, maybe research this better for next attempt. No time right now. Anyone else?

[remkos]

We had issues compiling cdo many times. Here is a bit of history.

• In PR cdo: update to 2.4.0 #23406 I tried compiler.blacklist-append { clang < 1300 } but then dropped it in favour of compiler.cxx_standard 2020
• In PR cdo: update to 2.4.1 #24069 I introduced compiler.blacklist-append clang and suggested that a more lenient compiler.blacklist-append { clang < 1500 } could be tried in some future PR. This also mentions the issue with "Ranges".
• In PRs cdo: update to 2.4.2 #24782, cdo: update to 2.4.3 #25434, cdo: update to 2.4.4 #26046, cdo: update to 2.5.0 #27304, cdo: update to 2.5.1 #27925, cdo: update to 2.5.2 #28494, and cdo: update to 2.5.3 #29133 compiler.blacklist-append clang was maintained.
• In PR cdo: fix for MacOS 10.14 #29167, in response to https://trac.macports.org/ticket/72869, I changed the way the CPP was selected. This may also have been because of "Ranges".
• In PR cdo: remove blacklisting and fix bug #29210 the compiler.blacklist-append clang was finally removed again, but this now appears premature.
• PRs cdo: update to 2.5.4 #30050 and cdo: update to 2.6.0 #31398 did without compiler.blacklist-append clang.
• In PR cdo: Legacy support for 10.13-10.14 #31751 @Dave-Allured introduced a new selection of legacysupport

From this, I would suggest to either reintroduce compiler.blacklist-append clang or try the more lenient compiler.blacklist-append { clang < 1500 } mentioned in PR #24069.

[Dave-Allured]

@remkos Thank you for the excellent recap. My blacklist attempt in this PR was rather naive on my part. I simply located a "ranges" fix in an unrelated Portfile, and copied it here. I am not surprised that it did not work.

It looks like you have a much better perspective on this port. Please feel free to run another PR if you think you have something good to try. Otherwise I will do a bit more research on the general "ranges" issue, and get back to this later. I am kinda busy for the next couple weeks.

CDO is in active and motivated maintenance under a stable institution. I have a lot of respect for this package. I do not think they would deliberately insert anything awkward into this code. However, it is likely that they have upgraded to advanced compiler requirements on general principles.