Skip to content

clang compilers: pick up non-darwin selections#32446

Open
holymonson wants to merge 1 commit intomacports:masterfrom
holymonson:clang
Open

clang compilers: pick up non-darwin selections#32446
holymonson wants to merge 1 commit intomacports:masterfrom
holymonson:clang

Conversation

@holymonson
Copy link
Copy Markdown
Contributor

@holymonson holymonson commented Apr 27, 2026

Description

${os.platform} ne "darwin" is first introduced in a24826e by @jmroot , and it has been duplicated many times.
Simplify it.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@reneeotten reneeotten requested a review from jmroot April 28, 2026 14:10
@reneeotten
Copy link
Copy Markdown
Contributor

reneeotten commented Apr 28, 2026

not completely convinced this simplifies anything as you're adding extra code. But I'll leave this to @jmroot to decide whether or not to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmroot jmroot Awaiting requested review from jmroot

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@holymonson @reneeotten