flux-markdown: new port#32298
Conversation
reneeotten
left a comment
There was a problem hiding this comment.
MacPorts is a build-from-source package manager and strongly prefers not to install pre-build binaries.
Please change the port such that it builds the source instead of downloading a .dmg file.
|
ping @xykong - can this be changed to build from source? |
Replace pre-built DMG installation with a proper build-from-source approach: - Download a MacPorts-specific source tarball (uploaded to GitHub Releases) that includes pre-generated FluxMarkdown.xcodeproj and pre-built web-renderer/dist, eliminating the need for xcodegen or npm at build time - Build with xcodebuild using ad-hoc signing (CODE_SIGN_IDENTITY='', CODE_SIGNING_REQUIRED=NO) - Sparkle auto-updater is removed from this build; MacPorts manages updates via port upgrade - Remove use_dmg in favor of use_xcode yes + standard build/destroot phases - Bump version to 1.31.402
|
Thank you for the review! I've updated the port to build from source. What changed:
Why a custom source tarball instead of the GitHub auto-generated one: The project uses XcodeGen to generate `.xcodeproj` from `project.yml` (xcodegen is not currently in MacPorts — see ticket #69285), and Vite/npm to build the TypeScript web renderer. Since neither tool is available in the MacPorts build sandbox, I publish a MacPorts-specific tarball alongside the DMG on each release:
This tarball is generated by Let me know if there are any other issues! |
reneeotten
left a comment
There was a problem hiding this comment.
Thanks for making the changes @xykong !
Instead of manually specifying the build and destroot phase and use_configure, can one use the xcode PortGroup instead? That PortGroup is intended to support xcode-based projects with setting sensible defaults.
See: https://github.com/macports/macports-ports/blob/master/_resources/port1.0/group/xcode-1.0.tcl
| # MacPorts-specific source tarball: pre-generated .xcodeproj, pre-built | ||
| # web-renderer/dist, and Sparkle removed (MacPorts manages updates). | ||
| # Generated by scripts/create_macports_tarball.sh during the release process. | ||
| distname FluxMarkdown-1.31.402-macports-source |
There was a problem hiding this comment.
| distname FluxMarkdown-1.31.402-macports-source | |
| distname FluxMarkdown-${version}-macports-source |
use ${version} to avoid the need to change this line upon each update
New port:
aqua/flux-markdownDescription
FluxMarkdown is a macOS QuickLook extension for Markdown files. It provides rich previews directly in Finder (press Space) with support for:
Homepage: https://github.com/xykong/flux-markdown
License: GPL-3
Stars: 600+
Platforms: macOS 12+ (Monterey and later,
darwin >= 21)Architectures: Universal (x86_64 + arm64)
Port details
use_dmg yes— no compilation requiredpost-activateremoves quarantine attribute, registers the QuickLook extension viapluginkit, and refreshes the QL daemon cachegithubPortGroup (GitHub Releases tags)Checklist
platforms {darwin >= 21}(requires macOS 12 Monterey for App Extensions)supported_archs x86_64 arm64githubPortGroup