-
Notifications
You must be signed in to change notification settings - Fork 376
Avoid failures when other runners are already registered with same name #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Avoid failures when other runners are already registered with same name #127
Conversation
Avoid failures when other runners are already registered with same name
|
this is awesome and was also causing us problems. |
|
Awesome fix! I am facing this problem right now on my builds... When this PR will be merged? |
It looks like it won't be that soon. If it helps we are using it like that: - name: Start EC2 runner
uses: kimetrica/ec2-github-runner@set-unique-name-in-UserData-script |
|
We are also running in the same issue, it would be great to see this merged soon |
|
I think we are also facing the issue at my company! Now that we ramped up the # of instances, its causing lots of failed runner registrations. I see repeated log lines on the machine with: @Preen Any chance we could get this PR merged and released? |
|
@humzam someone needs to fix the conflicts that are present. I dont have the time to do it right now sadly. |
|
@jeverling |
|
Yes, but not before next week.
…On Thu, Dec 11, 2025, 20:36 Philip Mannheimer ***@***.***> wrote:
*Preen* left a comment (machulav/ec2-github-runner#127)
<#127 (comment)>
@jeverling <https://github.com/jeverling>
Would you have time to fix the conflicts?
—
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5YWQYRQBMFVESEX5IGOL4BHBU5AVCNFSM6AAAAACOYVCIDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBTGQ4TMMZZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have updated the PR. There shouldn't be any more conflicts. |
|
It looks like you removed ? |
No, this was removed in the |
|
The diff looks good now 👍 |
Hi, we were running into issues where newly created instances weren't able to register with Github as runners, because by default the hostname is used as
--name, and AWS was reusing hostnames from our IP range.This can be fixed by setting the name explicitly, to something that is unique.
I think
--name $(hostname)-$(uuidgen)should work well.Fixes #128