Skip to content

Support dots in glimmer component names#341

Open
wmlele wants to merge 1 commit intomachty:masterfrom
wmlele:master
Open

Support dots in glimmer component names#341
wmlele wants to merge 1 commit intomachty:masterfrom
wmlele:master

Conversation

@wmlele
Copy link
Copy Markdown

@wmlele wmlele commented Apr 28, 2020

Primitive? attempt, looks ok for my purpose.

@kjhangiani
Copy link
Copy Markdown

the test should actually return <comp.name @value1={{foo}}/> rather than <comp.name @value1={{foo}}></comp.name> since its not used in a block context - will need to support both block and non-block contextual components

@wmlele
Copy link
Copy Markdown
Author

wmlele commented Jul 1, 2020

I agree, and l believe that is the subject of #338. Unfortunately that seems to be less trivial to fix than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants