Draft
Conversation
Signed-off-by: Thomas Jordan <thomas.jordan@check24.de>
Member
|
Logic for setting and handling of the new config key looks good but I think this is missing logic to actually have the instances write their logs to that path. Most systems run with the default of using /var/log/incus/ so having a path now ready at /var/lib/incus/logs/ with the pre-existing data moved there will not cause new instances from logging at the new location. Also another small wrinkle, running instances will not like their existing log files being moved across mounts, that will effectively break logging for those. So we should add a check so the config key can only be changed if the system has no running instances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #2484